feat: timetable frame v3 #1160
Merged
feat: timetable frame v3 #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
added
๊ธฐ๋ฅ
duehee
approved these changes
Jan 5, 2025
|
|
||
| @JsonNaming(value = SnakeCaseStrategy.class) | ||
| public record TimetableFrameCreateRequestV3( | ||
| @Schema(description = "ํ๊ธฐ ๋ ๋", example = "2019", requiredMode = REQUIRED) |
There was a problem hiding this comment.
A
๊ทธ๋ฅ ์ฐ๋๋ก ํ์ํด๋ ๊ด์ฐฎ์ ๊ฑฐ ๊ฐ์์!
There was a problem hiding this comment.
๋ต ๋ฐ์ํ๊ฒ ์ต๋๋ค !
| Integer id, | ||
|
|
||
| @Schema(description = "์๊ฐํ ์ด๋ฆ", example = "์๊ฐํ1", requiredMode = REQUIRED) | ||
| String timetableName, |
There was a problem hiding this comment.
C
TimetableFrame์ ๋ํ Response์ ๊ฐ์ด๋ผ๋ฉด ๊ทธ๋๋ก name ์จ๋ ๋์ง ์์๊น์?
There was a problem hiding this comment.
name์ด ์ ์ ํด๋ณด์ ๋๋ค ! ๋ฐ์ํ๊ฒ ์ต๋๋ค.
| return term; | ||
| } | ||
| } | ||
| throw new KoinIllegalArgumentException("term ์์์ด ์๋ชป๋์ต๋๋ค."); |
There was a problem hiding this comment.
A
์์ธ์ฒ๋ฆฌ ์๋ก ๋ง๋๋ ๊ฑด ๋ณ๋ก์ผ๊น์? ๐
There was a problem hiding this comment.
ํฐ ๋ฌธ์ ๋ ์์ ๊ฒ ๊ฐ์ต๋๋ค..! ์ปค์คํ ์์ธ๊ฐ ๋ ๋ช ํํ๊ฒ ๋ค์ฉ
kwoo28
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ฅ ์ฐ๊ด ์ด์
๐ ์์ ๋ด์ฉ
๐ฌ ๋ฆฌ๋ทฐ ์ค์ ์ฌํญ
timetableLecuture V3 ์ถฉ๋์ ๋ฐฉ์งํ๊ธฐ ์ํด timetableFrameRepository ์ฝ๋๋ฅผ ๋ช ๊ฐ ๊ธ์ด์์ต๋๋ค.
๋ฐฐ์ ํ์๊ณ ํ์ธํ์๋ฉด ๋ ๊ฒ ๊ฐ์ต๋๋ค.